Skip to content

Adjust spans correctly for fn -> method suggestion #114138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2023
Merged

Adjust spans correctly for fn -> method suggestion #114138

merged 1 commit into from
Jul 29, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #114131

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 27, 2023
@estebank
Copy link
Contributor

r? @estebank
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 28, 2023

📌 Commit b09091c has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned eholk Jul 28, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 28, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 28, 2023
@matthiaskrgr
Rollup merge of rust-lang#114138 - compiler-errors:bad-rcvr-span-on-m…
cc6c943 
…ethod-sugg, r=estebank

Adjust spans correctly for fn -> method suggestion

Fixes rust-lang#114131
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2023
@bors
Auto merge of rust-lang#114181 - matthiaskrgr:rollup-14m8s7f, r=matth…
ca1f813 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114099 (privacy: no nominal visibility for assoc fns )
 - rust-lang#114128 (When flushing delayed span bugs, write to the ICE dump file even if it doesn't exist)
 - rust-lang#114138 (Adjust spans correctly for fn -> method suggestion)
 - rust-lang#114146 (Skip reporting item name when checking RPITIT GAT's associated type bounds hold)
 - rust-lang#114147 (Insert RPITITs that were shadowed by missing ADTs that resolve to [type error])
 - rust-lang#114155 (Replace a lazy `RefCell<Option<T>>` with `OnceCell<T>`)
 - rust-lang#114164 (Add regression test for `--cap-lints allow` and trait bounds warning)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3aa8da1 into rust-lang:master Jul 29, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 29, 2023
@compiler-errors compiler-errors deleted the bad-rcvr-span-on-method-sugg branch August 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mrnossiom mrnossiom mrnossiom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

suggest_call_as_method in HIR type check hints incorrect code when dealing with macros
6 participants
@compiler-errors @rustbot @estebank @bors @mrnossiom @eholk